-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ttl to RedisCache #9068
add ttl to RedisCache #9068
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
libs/langchain/tests/integration_tests/cache/test_redis_cache.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glaucocustodio Thanks for the code contribution! I think it makes sense to add a ttl.
Requested a few minor changes, when you're ready could you request a re-review?
hey @eyurtsev, thanks for the review, I've done the requested changes, could you please take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Add `ttl` (time to live) to `RedisCache`
Add
ttl
(time to live) toRedisCache