add ttl to RedisCache #9068
Merged
add ttl to RedisCache #9068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
dosubot
bot
added
the
🤖:improvement
eyurtsev
reviewed
Aug 10, 2023
libs/langchain/tests/integration_tests/cache/test_redis_cache.py
Outdated
Show resolved
Hide resolved
eyurtsev
requested changes
Aug 10, 2023
There was a problem hiding this comment.
@glaucocustodio Thanks for the code contribution! I think it makes sense to add a ttl.
Requested a few minor changes, when you're ready could you request a re-review?
|
hey @eyurtsev, thanks for the review, I've done the requested changes, could you please take a look again? |
eyurtsev
approved these changes
Aug 14, 2023
toshish
pushed a commit
to toshish/langchain
that referenced
this pull request
Aug 14, 2023
Add `ttl` (time to live) to `RedisCache`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ttl(time to live) toRedisCache