-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[minor]: Add support for Couchbase Vector Store #4737
community[minor]: Add support for Couchbase Vector Store #4737
Conversation
* added couchbase document loader * fixed loader to use stringify * add doc file * updated tests * update types as per new requirement * update comments for typedoc * fix formatting issues and remove print in tests * add support for couchbase vector search using sdk * improved the params of couchbase * bump couchbase sdk version * remove rest implementation * add tsdoc * use initialize to create instance of class * improved tsdocs * add tests * add similarity search in documentation * add hybrid search in documentation and tests * remove unwanted files
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,60 @@ | |||
import { OpenAIEmbeddings } from "@langchain/openai"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code and flagged the addition of environment variable usage for the maintainers to review. It's important to ensure that sensitive information is handled securely. Let me know if you need further assistance with this.
@@ -122,6 +122,7 @@ | |||
"closevector-web": "0.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed that a new dependency "couchbase" with version "^4.2.11" has been added to the project. This change is being flagged for your review to ensure it aligns with the project's dependency requirements. Thank you!
@@ -0,0 +1,240 @@ | |||
/* eslint-disable @typescript-eslint/no-explicit-any */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that this PR includes changes that access environment variables using process.env
. I've flagged this for your review to ensure that the handling of environment variables aligns with best practices. Let me know if you need any further assistance with this!
@@ -0,0 +1,60 @@ | |||
import { OpenAIEmbeddings } from "@langchain/openai"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code and flagged the addition of environment variable usage for the maintainers to review. It's important to ensure that sensitive information is handled securely. Let me know if you need further assistance with this.
@@ -122,6 +122,7 @@ | |||
"closevector-web": "0.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed that a new dependency "couchbase" with version "^4.2.11" has been added to the project. This change is being flagged for your review to ensure it aligns with the project's dependency requirements. Thank you!
@@ -0,0 +1,240 @@ | |||
/* eslint-disable @typescript-eslint/no-explicit-any */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that this PR includes changes that access environment variables using process.env
. I've flagged this for your review to ensure that the handling of environment variables aligns with best practices. Let me know if you need any further assistance with this!
Is this still draft? |
@@ -64,6 +64,7 @@ | |||
"axios": "^0.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that the recent change in the package.json file added the "couchbase" dependency as a hard dependency. I'm flagging this for your review. Keep up the great work!
@@ -0,0 +1,66 @@ | |||
import { OpenAIEmbeddings } from "@langchain/openai"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code changes in the PR and flagged it for your review. The added code explicitly requires environment variables via process.env
, so it's important to ensure that the necessary environment variables are properly set and handled. Let me know if you need any further assistance with this!
@@ -122,6 +122,7 @@ | |||
"closevector-web": "0.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed that a new dependency "couchbase" with version "^4.3.0" has been added to the project. This change is flagged for your review to ensure it aligns with the project's dependency requirements. Keep up the great work!
@@ -0,0 +1,240 @@ | |||
/* eslint-disable @typescript-eslint/no-explicit-any */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that this PR includes changes that access environment variables using process.env
. I've flagged this for your review to ensure that the handling of environment variables aligns with best practices. Let me know if you need any further assistance with this!
Yes, it was draft due to a new Couchbase SDK Release as I had to test that out. It's done and ready for review now |
libs/langchain-community/src/vectorstores/tests/couchbase.int.test.ts
Outdated
Show resolved
Hide resolved
examples/src/indexes/vector_stores/couchbase/similaritySearch.ts
Outdated
Show resolved
Hide resolved
Looks good! Small nit if you can change the env var names but otherwise looks good. |
Changed it myself, thank you! |
Add support for Vector Store in Couchbase, a distributed NoSQL database.
Dependencies:
Added the Couchbase SDK as an optional dependency to langchain community.