Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: Support configurable search parameters for Milvus #5877

Merged
merged 3 commits into from
Jul 4, 2024
Merged

community[minor]: Support configurable search parameters for Milvus #5877

merged 3 commits into from
Jul 4, 2024

Conversation

yokingma
Copy link
Contributor

Description

  • Support configurable search parameters for Milvus.
  • Fixed some annotation errors.
  • Refactored some code.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 24, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 4:33am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 3, 2024 4:33am

@dosubot dosubot bot added auto:improvement Medium size change to existing code to handle new use-cases auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jun 24, 2024
jacoblee93
jacoblee93 reviewed Jun 25, 2024
View reviewed changes
libs/langchain-community/src/vectorstores/milvus.ts

constructor(embeddings: EmbeddingsInterface, args: MilvusLibArgs) {
constructor(public embeddings: EmbeddingsInterface, args: MilvusLibArgs) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

@jacoblee93 jacoblee93 added the question Further information is requested label Jun 25, 2024
@jacoblee93
Copy link
Collaborator

A few changes that look breaking unless Milvus updated their APIs - can try it myself if you add a test?

@jacoblee93
Copy link
Collaborator

jacoblee93 commented Jul 2, 2024 •
edited
Loading

Thank you for reviewing @zhanshuyou!

@jacoblee93 jacoblee93 merged commit 12bf5ff into langchain-ai:main Jul 4, 2024
37 checks passed
@jacoblee93 jacoblee93 added lgtm PRs that are ready to be merged as-is and removed question Further information is requested labels Jul 4, 2024
This was referenced Jul 24, 2024
Merged
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 1, 2024
Open
This was referenced Aug 2, 2024
Open
Open
@filipeoliveiraa filipeoliveiraa mentioned this pull request Aug 4, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Aug 6, 2024
Merged
@steve-hb steve-hb mentioned this pull request Aug 6, 2024
Open
This was referenced Aug 12, 2024
Closed
Closed
This was referenced Aug 12, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanshuyou zhanshuyou zhanshuyou approved these changes

@jacoblee93 jacoblee93 jacoblee93 left review comments

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yokingma @jacoblee93 @zhanshuyou