Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: cheerio loader fetch headers type error #5905

Merged
merged 4 commits into from
Jun 28, 2024
Merged

community[patch]: cheerio loader fetch headers type error #5905

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7beac60
fix: cheerio loader fetch headers type error
Jun 26, 2024
18831f1
Merge branch 'main' into fix/cheerio_fetch_headers_type
bracesproul Jun 26, 2024
70e6bc6
Merge branch 'main' of https://github.com/langchain-ai/langchainjs in…
bracesproul Jun 28, 2024
5593449
fix ci
bracesproul Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/langchain-community/src/document_loaders/web/cheerio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class CheerioWebBaseLoader

textDecoder?: TextDecoder;

headers?: Headers;
headers?: HeadersInit;

constructor(public webPath: string, fields?: WebBaseLoaderParams) {
super();
Expand All @@ -86,7 +86,7 @@ export class CheerioWebBaseLoader
timeout: number | undefined,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just wanted to flag that the recent change in cheerio.ts introduces a potential new external HTTP request using fetch. This is flagged for your review to ensure it aligns with the project's requirements. Great work overall!

textDecoder?: TextDecoder,
options?: CheerioOptions & {
headers?: Headers;
headers?: HeadersInit;
}
): Promise<CheerioAPI[]> {
return Promise.all(
Expand All @@ -102,7 +102,7 @@ export class CheerioWebBaseLoader
timeout: number | undefined,
textDecoder?: TextDecoder,
options?: CheerioOptions & {
headers?: Headers;
headers?: HeadersInit;
}
): Promise<CheerioAPI> {
const { headers, ...cheerioOptions } = options ?? {};
Expand Down