-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jacob/5890 #5956
jacob/5890 #5956
Conversation
…ation feat: add mixedbread ai integration
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,89 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 This PR includes changes to the peer and dev dependencies of the project, as well as an update to the minimum required Node.js version. I've flagged this for your review to ensure the changes align with the project's requirements. Keep up the great work! 🚀
@@ -0,0 +1,179 @@ | |||
import { getEnvironmentVariable } from "@langchain/core/utils/env"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I noticed that the recent code changes explicitly add, access, read, or require an environment variable via process.env
or getEnvironmentVariable
. I've flagged this for the maintainers to review and ensure that the handling of environment variables aligns with best practices. Great work on the PR!
@@ -0,0 +1,198 @@ | |||
import { DocumentInterface } from "@langchain/core/documents"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code and it looks great. I've left a comment flagging the use of environment variables for the maintainers to review. Keep up the good work!
@jacoblee93 Looks good to me! Please merge from here :) |
Thank you! Live here: https://www.npmjs.com/package/@langchain/mixedbread-ai |
🙏 |
@juliuslipp