fix(mongodb): mongodb storage mget must return undefined when key not exist #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:M
jacoblee93
reviewed
Aug 16, 2024
| ); | ||
|
|
||
| return keys.map((key) => { | ||
| const prefixedKey = this._getPrefixedKey(key); |
There was a problem hiding this comment.
Should just map over prefixedKeys?
jacoblee93
reviewed
Aug 16, 2024
| const prefixedKey = this._getPrefixedKey(key); | ||
| const value = valueMap.get(prefixedKey); | ||
|
|
||
| if (!value || !("value" in value)) { |
There was a problem hiding this comment.
valueMap contains tuples now, so this would never be true?
There was a problem hiding this comment.
I agree, the second part of the condition was removed.
|
Sorry for the delay! A few questions |
|
Someone is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
not a problem. review updated. please have a look. |
|
@jacoblee93 can you please merge it? |
|
Sorry about the delay, will ship shortly! |
jacoblee93
approved these changes
Sep 4, 2024
jacoblee93
changed the title
This was referenced Sep 12, 2024
This was referenced Sep 14, 2024
This was referenced Oct 3, 2024
This was referenced Oct 5, 2024
CarterMorris
pushed a commit
to CarterMorris/langchainjs
that referenced
this pull request
Nov 10, 2024
… exist (langchain-ai#6445) Co-authored-by: Roman Tyshyk <roman.tyshyk@711media.de> Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6441 (issue)
mgetmethod inBaseStoremust return values or undefined in the same order as the input keys.PR is fixing MongoDB storage implementation.