Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: support modelName param and update default fireworks model to Llama 3.1 8B #6450

Merged
merged 1 commit into from
Aug 7, 2024
Merged

community[patch]: support modelName param and update default fireworks model to Llama 3.1 8B #6450

merged 1 commit into from
Aug 7, 2024

Conversation

henryweng03
Copy link
Contributor

@henryweng03 henryweng03 commented Aug 7, 2024 •
edited
Loading

  • ChatFireworks manifest sometimes uses modelName to define the model, which incorrectly leads to defaulting to the default model
  • Existing default model has been deprecated by Fireworks, causing it to error out. Update default model to llama-3.1-8b

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 7, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 9:58pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 7, 2024 9:58pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Aug 7, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 changed the title fix: support modelName param and update default fireworks model to Llama 3.1 8B community[patch]: support modelName param and update default fireworks model to Llama 3.1 8B Aug 7, 2024
@jacoblee93 jacoblee93 merged commit 7696d4f into langchain-ai:main Aug 7, 2024
33 checks passed
@jacoblee93
Copy link
Collaborator

Thank you!

This was referenced Aug 12, 2024
Closed
Closed
@prathik2401 prathik2401 mentioned this pull request Aug 31, 2024
Closed
@riderx riderx mentioned this pull request Aug 31, 2024
Closed
@prathik2401 prathik2401 mentioned this pull request Sep 1, 2024
Closed
@lholmquist lholmquist mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryweng03 @jacoblee93