-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-genai[minor]: Add support for json output #6519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Aug 13, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
Medium size change to existing code to handle new use-cases
label
Aug 13, 2024
bracesproul
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pushing these updates! It would be great if you could also push up a test verifying this mode works as intended. Thank you!
bracesproul
changed the title
support json output for google-genai
google-genai[minor]: Add support for json output
Aug 15, 2024
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Aug 16, 2024
Thank you! |
This was referenced Sep 7, 2024
This was referenced Sep 13, 2024
CarterMorris
pushed a commit
to CarterMorris/langchainjs
that referenced
this pull request
Nov 10, 2024
* support json output for google-genai * Apply suggestions from code review * Add test --------- Co-authored-by: juji <him@jujiyangasli.com> Co-authored-by: Brace Sproul <braceasproul@gmail.com> Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support JSON output with google-genai, by adding a
json: true
to instance initialization.Example:
Usage Example: