core[patch]: Pass input to invocation for JSON schema tools #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:bug
jacoblee93
approved these changes
Aug 16, 2024
This was referenced Sep 7, 2024
This was referenced Sep 13, 2024
CarterMorris
pushed a commit
to CarterMorris/langchainjs
that referenced
this pull request
Nov 10, 2024
…n-ai#6549) * core[patch]: Pass input to invocation for JSON schema tools * Lint * Use type guard instead of instanceof --------- Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6306 introduced the ability to pass JSON Schema instead of Zod instances into the
schemaoftool()orDynamicStructuredTool. This would skip the input validation on the Langchain side but it introduced two bugs that this PR addresses:{}as input since the fallback Zod schema that was used during initialization would map toz.object({})which when used withschema.parseAsync(input)results in all properties being dropped. To get around this we need to usepassthrough()to tell Zod not to drop any additional properties.tool()function is checking if a schema is not an object Zod schema and then returns aDynamicToolinstance instead of aDynamicStructuredToolinstance. This results in the resulting Tool execution always passingundefinedas input. Insteadtool()needs to check that if the inputschemais defined that it's not an instance of a ZodType before checking any other conditions.This is my first contribution so I'm not sure if I missed anything but the tests seemed to pass.
My Twitter handle is
dkundel.