Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(community): Add support for Bedrock cross-region inference models #6682

Merged
merged 5 commits into from
Sep 4, 2024
Merged

fix(community): Add support for Bedrock cross-region inference models #6682

merged 5 commits into from
Sep 4, 2024

Conversation

keremnalbant
Copy link
Contributor

Hey, I recently I switched to Bedrock Inference models.

In the constructors of Bedrock and BedrockChat, we were throwing the error Unknown model:.

Basically, I've introduced a utility function to check if the modelId belongs to an inference model or not.

Fixes #6681

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 3, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 4, 2024 10:17pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Sep 4, 2024 10:17pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Sep 3, 2024
@dosubot dosubot bot mentioned this pull request Sep 4, 2024
Closed
5 tasks
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 changed the title Add support for Bedrock cross-region inference models fix(community): Add support for Bedrock cross-region inference models Sep 4, 2024
@jacoblee93 jacoblee93 merged commit 29c5b8c into langchain-ai:main Sep 4, 2024
33 checks passed
This was referenced Sep 7, 2024
Closed
Merged
@keremnalbant keremnalbant mentioned this pull request Sep 8, 2024
Closed
@bruno353 bruno353 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 12, 2024
Open
Open
@bruno353 bruno353 mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
@bruno353 bruno353 mentioned this pull request Sep 17, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 26, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
@lholmquist lholmquist mentioned this pull request Oct 3, 2024
Closed
@davidebukali davidebukali mentioned this pull request Oct 3, 2024
Open
@lholmquist lholmquist mentioned this pull request Oct 5, 2024
Closed
@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bedrock Inference Model IDs are out of support.
2 participants
@keremnalbant @jacoblee93