Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(community): add libsql vectorstore #6904

Merged
merged 14 commits into from
Oct 7, 2024
Merged

feat(community): add libsql vectorstore #6904

merged 14 commits into from
Oct 7, 2024

Conversation

notrab
Copy link
Contributor

@notrab notrab commented Sep 30, 2024

This PR adds libSQL as a vectorstore option with some basic examples and docs.

Notes

  • It currently doesn't properly support metadata filtering, but we're seeking ways with our community on the best developer experience for this and will follow up on this PR.
  • I could not run the npx command to initialize the new integration folder. So I did what I could manually to replicate.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 30, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Oct 7, 2024 9:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Oct 7, 2024 9:42pm

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Sep 30, 2024
jacoblee93
jacoblee93 reviewed Oct 4, 2024
View reviewed changes
docs/core_docs/docs/integrations/vectorstores/libsql.mdx
@@ -0,0 +1,112 @@
# libSQL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the docs follow this template?

https://github.com/langchain-ai/langchainjs/blob/main/libs/langchain-scripts/src/cli/docs/templates/vectorstores.ipynb

I need to update the contributing instructions...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacoblee93 I updated the docs to follow more closely your example, however if you have time, please suggest or commit any changes you desire.

@jacoblee93
Copy link
Collaborator

Hey @notrab, sorry for the delay - left a few minor comments but overall looks good.

I may be able to spend some time reformatting things next week if you don't have time.

@jacoblee93 jacoblee93 added the close PRs that need one or two touch-ups to be ready label Oct 4, 2024
@notrab
Copy link
Contributor Author

notrab commented Oct 4, 2024

@jacoblee93 perfect, thank you. I’ll take another pass at this Monday/Tuesday and see what you think. Thanks very much

@notrab notrab requested a review from jacoblee93 October 7, 2024 10:35
@jacoblee93 jacoblee93 changed the title feat: add libsql vectorstore feat(community): add libsql vectorstore Oct 7, 2024
@jacoblee93 jacoblee93 removed the close PRs that need one or two touch-ups to be ready label Oct 7, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Oct 7, 2024
@jacoblee93 jacoblee93 merged commit f9f1b7f into langchain-ai:main Oct 7, 2024
37 checks passed
@jacoblee93
Copy link
Collaborator

Thanks! Will ship tonight.

@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacoblee93 jacoblee93 Awaiting requested review from jacoblee93

Assignees
No one assigned
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notrab @jacoblee93