Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(community): Add new LLM provider Novita AI #7231

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(community): Add new LLM provider Novita AI #7231

wants to merge 6 commits into from
+458 −0

Conversation

jasonhp
Copy link

@jasonhp jasonhp commented Nov 19, 2024

Add new LLM API provider Novita AI.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 19, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 22, 2024 9:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 22, 2024 9:53am

@dosubot dosubot bot added auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Nov 19, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@jasonhp
Copy link
Author

jasonhp commented Nov 19, 2024 •
edited
Loading

Hi @jacoblee93 I have finished adding the new LLM provider Novita AI but the Vercel – langchainjs-docs deployment failed. I cannot see the details on Vercel. I have successfully run yarn build locally inside docs/core_docs. Can you have a check at your convenience?

@jacoblee93 jacoblee93 changed the title Add new LLM provider Novita AI feat(community): Add new LLM provider Novita AI Nov 22, 2024
jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
docs/core_docs/docs/integrations/chat/novita.ipynb Outdated
"## Overview\n",
"\n",
"### Model features\n",
"| [Tool calling](../../how_to/tool_calling.ipynb) | [Structured output](../../how_to/structured_output.ipynb) | JSON mode | [Image input](../../how_to/multimodal_inputs.ipynb) | Audio input | Video input | [Token-level streaming](../../how_to/chat_streaming.ipynb) | Native async | [Token usage](../../how_to/chat_token_usage_tracking.ipynb) | [Logprobs](../../how_to/logprobs.ipynb) |\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these need to be absolute paths rather than relative

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
docs/core_docs/docs/integrations/chat/novita.ipynb Outdated
"source": [
"## Chaining\n",
"\n",
"We can [chain](../../how_to/sequence.ipynb) our model with a prompt template like so:"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
docs/core_docs/docs/integrations/chat/novita.ipynb Outdated
"source": [
"## API reference\n",
"\n",
"For detailed documentation of Novita AI LLM APIs, head to [Novita AI API reference](https://novita.ai/docs/model-api/reference/llm/llm.html?utm_source=github_langchain&utm_medium=github_readme&utm_campaign=link)\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer having this link to the LangChain API refs, but this is ok too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm truly sorry but I don't have more time to write a Novita API ref for LangChain 😭.

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
docs/core_docs/docs/integrations/chat/novita.mdx Outdated
---

import CodeBlock from "@theme/CodeBlock";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have this and the notebook above - the notebook compiles into an .mdx file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this file

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
examples/src/models/chat/integration_novita.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, see above. The notebook is all you need

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
examples/src/models/chat/integration_novita_chain.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, see above. The notebook is all you need

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
libs/langchain-community/langchain.config.js Outdated
@@ -113,6 +113,7 @@ export const config = {
"llms/writer": "llms/writer",
"llms/yandex": "llms/yandex",
"llms/layerup_security": "llms/layerup_security",
"llms/novita": "llms/novita",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be chat_models/novita

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
libs/langchain-community/package.json Outdated
@@ -35,7 +35,7 @@
"author": "LangChain",
"license": "MIT",
"dependencies": {
"@langchain/openai": ">=0.2.0 <0.4.0",
"@langchain/openai": "workspace:*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

jacoblee93
jacoblee93 reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good overall. See comments!

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 22, 2024
@jasonhp
Copy link
Author

jasonhp commented Nov 22, 2024

Thanks, looks good overall. See comments!

Thank you so much for reviewing and all the problems above have been solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 left review comments

Assignees
No one assigned
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonhp @jacoblee93