Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FalkorDB support #7367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Naseem77
Copy link

@Naseem77 Naseem77 commented Dec 15, 2024

Adding FalkorDB Graph store support

Ref to: #2741

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 15, 2024
Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Dec 15, 2024 11:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 15, 2024 11:32am

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Dec 15, 2024
@gkorland gkorland mentioned this pull request Dec 15, 2024
@gkorland
Copy link

@jacoblee93 this PR is replacing the original PR #2774

Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for the wait!

I'm not terribly familiar with Falkor/Cypher internals - would just say to triple check there are no potential injection issues

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's call this just graphs/falkordb.ts since its already in the graphs/ folder

Will need to change entrypoints above


const chain = GraphCypherQAChain.fromLLM({
llm: model,
graph,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we'll need to change the GraphCypherQAChain typing here?

@@ -223,6 +223,7 @@ export const config = {
// graphs
"graphs/neo4j_graph": "graphs/neo4j_graph",
"graphs/memgraph_graph": "graphs/memgraph_graph",
"graphs/memgraph_graph": "graphs/falkordb_graph",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix entrypoint name

@@ -0,0 +1,154 @@
import { createClient } from "redis";
import { Graph } from "redisgraph.js";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a new dep right?

Please add it to package.json as shown here:

https://github.com/langchain-ai/langchainjs/blob/main/.github/contributing/INTEGRATIONS.md#third-party-dependencies

@jacoblee93 jacoblee93 added the in progress PRs that are in progress but not ready to merge label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features in progress PRs that are in progress but not ready to merge size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants