-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FalkorDB support #7367
base: main
Are you sure you want to change the base?
add FalkorDB support #7367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@jacoblee93 this PR is replacing the original PR #2774 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for the wait!
I'm not terribly familiar with Falkor/Cypher internals - would just say to triple check there are no potential injection issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's call this just graphs/falkordb.ts
since its already in the graphs/
folder
Will need to change entrypoints above
|
||
const chain = GraphCypherQAChain.fromLLM({ | ||
llm: model, | ||
graph, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we'll need to change the GraphCypherQAChain
typing here?
@@ -223,6 +223,7 @@ export const config = { | |||
// graphs | |||
"graphs/neo4j_graph": "graphs/neo4j_graph", | |||
"graphs/memgraph_graph": "graphs/memgraph_graph", | |||
"graphs/memgraph_graph": "graphs/falkordb_graph", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix entrypoint name
@@ -0,0 +1,154 @@ | |||
import { createClient } from "redis"; | |||
import { Graph } from "redisgraph.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a new dep right?
Please add it to package.json
as shown here:
Adding FalkorDB Graph store support
Ref to: #2741