langgraph: more checkpointer tests #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
reviewed
Aug 7, 2024
| }, | ||
| "pending_sends": [], | ||
| "current_tasks": {}, | ||
| assert saved.checkpoint["channel_values"] == { |
There was a problem hiding this comment.
why does this need to change?
There was a problem hiding this comment.
i removed because of the different version types/formats across different checkpointers, but i can also make something like AnyVersion that will just ignore those fields / customize memory saver for tests to return strings and use AnyStr. wdyt?
nfcampos
approved these changes
Aug 8, 2024
|
I think there's still a bunch of tests where we test a single checkpointer. The end goal here should be to remove the imports of MemorySaver and SqliteSaver from test_pregel and test_pregel_async |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.