[Bug Fix] retry_on handling and add support for lists in RetryPolicy #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `retry_on` in `RetryPolicy` accepted only exception classes, tuples of exception classes, or callables. Update the `retry_on` type annotation to include `List[Type[Exception]]` Changes: - Updated `retry_on` in `RetryPolicy` to accept `List[Type[Exception]]`.
- Correctly distinguish between exception classes, lists/tuples of exception classes, and callables. - Add support for lists in `retry_on`, alongside tuples. - Prevent exception classes from being incorrectly treated as callables. - Raise a `TypeError` if `retry_on` is of an unsupported type.
|
Thanks for this! Made a few updates, will merge it once CI finishes |
nfcampos
approved these changes
Sep 18, 2024
|
Thank you. |
|
@Etelis in the past we faced some issues with getting mypy to behave with our codebase. I can try to see if mypy has improved since, but would probably be a fairly involved task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues in the run_with_retry function:
Exception Classes Misidentified as Callables:
Issue: Exception classes are callable, leading callable(retry_policy.retry_on) to mistakenly treat them as callables for custom retry logic.
No Support for Lists in retry_on:
Issue: retry_on accepted only exception classes, tuples, or callables, not lists of exceptions (as defined in the documentation)
Summary of Changes: