Enable mypy for langgraph lib #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
changed the title
hinthornw
approved these changes
Sep 19, 2024
| self, checkpoint: Optional[C], config: RunnableConfig | ||
| ) -> Generator[Self, None, None]: ... | ||
|
|
||
| async def afrom_checkpoint( |
There was a problem hiding this comment.
This was removed from the actual lib a while ago, but had been left in this protocol in checkpoint lib
| def __init__(self, typ: Type[Value], names: set[Value]) -> None: | ||
| super().__init__(typ) | ||
| self.names = names | ||
| self.seen = set() | ||
| self.seen: set[str] = set() |
There was a problem hiding this comment.
Why type as str rather than Value ?
| @@ -702,11 +714,23 @@ def _get_channels( | |||
| if name != "__slots__" | |||
| } | |||
| return ( | |||
| {k: v for k, v in all_keys.items() if not is_managed_value(v)}, | |||
| {k: v for k, v in all_keys.items() if isinstance(v, BaseChannel)}, | |||
There was a problem hiding this comment.
Because mypy doesn't know that everything that isn't a managed value is a base channel
| tools: Union[ToolExecutor, Sequence[BaseTool], ToolNode], | ||
| *, | ||
| state_schema: Optional[StateSchemaType] = None, | ||
| messages_modifier: Optional[MessagesModifier] = None, | ||
| state_modifier: Optional[StateModifier] = None, | ||
| checkpointer: Optional[BaseCheckpointSaver] = None, | ||
| interrupt_before: Optional[Sequence[str]] = None, | ||
| interrupt_after: Optional[Sequence[str]] = None, | ||
| interrupt_before: Optional[list[str]] = None, |
There was a problem hiding this comment.
ooc - why the change here?
There was a problem hiding this comment.
Because the type accepted by compile changed too
| @@ -1,10 +1,13 @@ | |||
| # type: ignore | |||
Co-authored-by: William FH <13333726+hinthornw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.