Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception if sync method on async checkpointer is called from event loop thread #1803

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Raise exception if sync method on async checkpointer is called from event loop thread #1803

merged 1 commit into from
Sep 23, 2024
+24 −0

Conversation

nfcampos
Copy link
Contributor

@nfcampos nfcampos commented Sep 23, 2024 •
edited
Loading

  • The thread running the event loop can block waiting for a coro to run, only background threads can

Closes #1800

@nfcampos
Raise exception if sync method on async checkpointer is called from m…
e71c24e 
…ain thread

- The thread running the event loop can block waiting for a coro to run, only background threads can
@nfcampos nfcampos marked this pull request as ready for review September 23, 2024 15:42
@nfcampos nfcampos merged commit 68c1fa8 into main Sep 23, 2024
46 checks passed
@nfcampos nfcampos deleted the nc/23sep/exc-async-checkpointer-block branch September 23, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarda vbarda vbarda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a graph containing async checkpointer is incorrectly used with invoke or get_state, the program will hang
2 participants
@nfcampos @vbarda