sdk-py: added Cron search functionality #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akira
reviewed
Jun 25, 2024
libs/sdk-py/langgraph_sdk/client.py
Outdated
| elif assistant_id: | ||
| return await self.http.get(f"/assistants/{assistant_id}/runs/crons") | ||
| else: | ||
| return await self.http.get(f"runs/crons") |
There was a problem hiding this comment.
assistant_id should be required for cron also (similar to run)
akira
reviewed
Jun 25, 2024
libs/sdk-py/langgraph_sdk/client.py
Outdated
| @@ -687,6 +687,20 @@ async def create( | |||
| async def delete(self, cron_id: str) -> None: | |||
| """Delete a cron.""" | |||
| await self.http.delete(f"/runs/crons/{cron_id}") | |||
|
|
|||
| async def list( | |||
akira
reviewed
Jun 25, 2024
libs/sdk-py/langgraph_sdk/client.py
Outdated
| "thread_id": thread_id, | ||
| } | ||
| payload = {k: v for k, v in payload.items() if v is not None} | ||
| return await self.http.post(f"/runs/crons/search", json=payload) |
There was a problem hiding this comment.
don't need f"" since there's no replacements
…into isaac/cronlist
libs/sdk-py/langgraph_sdk/client.py
Outdated
| @@ -412,8 +412,7 @@ def stream( | |||
| interrupt_after: Optional[list[str]] = None, | |||
| feedback_keys: Optional[list[str]] = None, | |||
| multitask_strategy: Optional[MultitaskStrategy] = None, | |||
| ) -> AsyncIterator[StreamPart]: | |||
| ... | |||
| ) -> AsyncIterator[StreamPart]: ... | |||
There was a problem hiding this comment.
This is causing the lint error. The ellipse (...) should be on a new line. Undo this change and all of the other instances and you should be good to go!
) -> AsyncIterator[StreamPart]:
...
isahers1
changed the title
vbarda
reviewed
Jun 27, 2024
vbarda
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.