langgraph[patch]: ToolNode support for tools outputting msg #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baskaryan
changed the title
hinthornw
reviewed
Jul 15, 2024
| content=str_output(output), name=call["name"], tool_call_id=call["id"] | ||
| ) | ||
| content = f"Error: {repr(e)}\n Please fix your mistakes." | ||
| return ToolMessage(content, name=call["name"], tool_call_id=call["id"]) |
There was a problem hiding this comment.
why are we no lnoger passing content by keyword?
There was a problem hiding this comment.
cleaner this way (imo), messages accept content as pos arg
|
So tools always return a tool message in this formulation? I must have missed where we guarantee this; it' sin the TOolCall itself? |
tools always return tool message if input is a ToolCall with "type" and "id" set |
vbarda
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After langchain-ai/langchain#24038, tools will be able to take in typed ToolCalls directly and will output a ToolMessage when invoked with a ToolCall
Requires
langchain-core==0.2.16to be released