-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground UX fixes #119
Playground UX fixes #119
Conversation
}; | ||
} | ||
|
||
class AIMessageChunk { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to handle FunctionMessageChunk later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, need to handle FunctionMessageChunk as well, will look into it in another PR
props.uischemas | ||
); | ||
|
||
const selectedIndex = anyOfRenderInfos.length - 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment may not make sense -- i have no idea what the code is supposed to do
Why is this hard-coded to the last index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is to get rid of the tabs altogether, as it doesn't make sense to show all possible union options in a nice way and if I recall correctly, only non-prompt inputs do include anyOf
in our templates.
Can revisit later with a dropdown style input instead, but this should work fine for now.
xmlns="http://www.w3.org/2000/svg" | ||
> | ||
<path | ||
d="M100 50.5908C100 78.2051 77.6142 100.591 50 100.591C22.3858 100.591 0 78.2051 0 50.5908C0 22.9766 22.3858 0.59082 50 0.59082C77.6142 0.59082 100 22.9766 100 50.5908ZM9.08144 50.5908C9.08144 73.1895 27.4013 91.5094 50 91.5094C72.5987 91.5094 90.9186 73.1895 90.9186 50.5908C90.9186 27.9921 72.5987 9.67226 50 9.67226C27.4013 9.67226 9.08144 27.9921 9.08144 50.5908Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this draw a parrot?
anyOf
handlingadditional_kwargs
are not shown in the outputCloses #105, #110