Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofill of chat history, fix turnstile chat history #157

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented Nov 2, 2023

CleanShot.2023-11-02.at.15.43.06.mp4
  • Handle function calls and additional kwargs in List[*Message]
  • Handle Tuple[message,message] alongside Tuple[role, message]

@cla-bot cla-bot bot added the cla-signed label Nov 2, 2023
@dqbd dqbd changed the title Add autofill of chat history Add autofill of chat history, fix turnstile chat history Nov 2, 2023
@dqbd dqbd requested review from nfcampos and eyurtsev November 2, 2023 14:57
@eyurtsev
Copy link
Collaborator

eyurtsev commented Nov 3, 2023

Is it easy to change the 2 column layout into something that looks more like a regular chat interface? i.e., 1 column of messages

I don't think we want to visualize hard-code the notion of request-response since the response could in the future consist of multiple messages, and there could be multiple entities (not just user and AI)

examples/widgets/server.py Outdated Show resolved Hide resolved
examples/widgets/server.py Show resolved Hide resolved
@jacoblee93
Copy link
Collaborator

Seems good to me!

@dqbd dqbd merged commit 180694e into main Nov 3, 2023
6 checks passed
@dqbd dqbd deleted the dqbd/playground-chat-history branch November 3, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants