Unpack input recursively, to ensure that sub-types that are expected … #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to remain as BaseModel do
eyurtsev
approved these changes
Nov 6, 2023
| @@ -120,7 +120,10 @@ def _unpack_input(validated_model: BaseModel) -> Any: | |||
| # it was created by the server as part of validation and isn't expected | |||
| # to be accepted by the runnables as input as a pydantic model, | |||
| # instead we need to convert it into a corresponding python dict. | |||
| return model.dict() | |||
| return { | |||
| fieldname: _unpack_input(getattr(model, fieldname)) | |||
There was a problem hiding this comment.
Awesome looks good, I'll update the comment and can release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to remain as BaseModel do
This fixes input types such as