Fix URL Parse #352
Merged
Fix URL Parse #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic to fetch the langsmith host url unintentionally turns the default langsmith url of `https://api.smith.langchain.com` into an invalid url of `https:/.smith.langchain.com` because it matches on the /api portion. This PR changes the logic to exempt those cases where the subdomain begins with `api` so that the correct host url is returned. Co-authored-by: Shmuel Lamm <shmuellamm@gmail.com>
hinthornw
force-pushed
the
wfh/fix_url_parse
branch
from
5b1b975 to
a0f5320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.