Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing public link issue on page reload #128

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

NaikMegha
Copy link
Contributor

There was a bug in the Public URL feature that caused the shared_id to be added repeatedly when the page loaded. (http://localhost:5173/?shared_id=474f465e-9701-4bdd-90a4- 392ac966ce94?shared_id=474f465e-9701-4bdd-90a4-392ac966ce94)

To rectify this issue, we implemented a flag in the code to generate the public link only if it is not already available. If the link exists, it will utilize the existing one.

@nfcampos nfcampos merged commit 4200fe1 into langchain-ai:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants