Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable slack_webhook tool to request webhook URL based on Slack workflow #6041

Closed
5 tasks done
mabuchs opened this issue Jul 7, 2024 · 0 comments · Fixed by #6042
Closed
5 tasks done

Enable slack_webhook tool to request webhook URL based on Slack workflow #6041

mabuchs opened this issue Jul 7, 2024 · 0 comments · Fixed by #6042
Labels
💪 enhancement New feature or request

Comments

@mabuchs
Copy link
Contributor

mabuchs commented Jul 7, 2024 •
edited
Loading

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

I'd like to create agent app on dify.
Since my slack workspace uses many workflows, I'd like dify agent to send requests to incoming webhook URL for workflows (https://hooks.slack.com/workflows/xxxxxxxxxx).
Since current URL validation doesn't allow this url, I can't achieve it.
https://github.com/ericyangpan/dify/blob/e7d0640c8b556c4c3d08aa809cf1433f9dd716f9/api/core/tools/provider/builtin/slack/tools/slack_webhook.py#L23

2. Additional context or comments

No response

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
@dosubot dosubot bot added the 💪 enhancement New feature or request label Jul 7, 2024
mabuchs pushed a commit to mabuchs/dify that referenced this issue Jul 7, 2024
Modify slack webhook url validation to allow workflow (langgenius#6041)
8580f00
@mabuchs mabuchs mentioned this issue Jul 7, 2024
Merged
10 tasks
crazywoola pushed a commit that referenced this issue Jul 7, 2024
@mabuchs
Modify slack webhook url validation to allow workflow (#6041) (#6042)
91c5818 
Co-authored-by: Shunsuke Mabuchi <mabuchs@amazon.co.jp>
ZhouhaoJiang added a commit that referenced this issue Jul 9, 2024
@ZhouhaoJiang
Merge branch 'refs/heads/main' into feat/if-elif
d98472c 
* refs/heads/main: (51 commits)
  feat: tailwind related improvement (#6085)
  feat: support AnalyticDB vector store (#5586)
  feat:add tts-streaming config and future (#5492)
  Feat: add index bar to select tool panel of workflow (#6066)
  bump to 0.6.13 (#6078)
  fix: Inconsistency Between Actual and Debug Input Variables (#6055)
  refactor: revamp picker block (#4227)
  chore: remove tsne unused code (#6077)
  fix: relative in overflow div (#5998)
  chore(action): move docker login above Set up QEMU in build-push action workflow (#6073)
  remove clunky welcome message (#6069)
  feat: add request_params field to jina_reader tool (#5610)
  fix azure stream download (#6063)
  chore: hide tracing introduce detail (#6049)
  Address the issue of the absence of poetry in the development container. (#6036)
  Fix authorization header validation to handle bearer types correctly - "authorization config header is required" error (#6040)
  Fix/6034 get random order of categories in explore and workflow is missing in zh hant (#6043)
  Modify slack webhook url validation to allow workflow (#6041) (#6042)
  fix(configs): Update pydantic settings in config files (#6023)
  Fix/incorrect parameter extractor memory (#6038)
  ...
laipz8200 pushed a commit that referenced this issue Jul 10, 2024
@mabuchs @laipz8200
Modify slack webhook url validation to allow workflow (#6041) (#6042)
d13b7a7 
Co-authored-by: Shunsuke Mabuchi <mabuchs@amazon.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify slack webhook url validation to allow workflow (#6041) mabuchs/dify
1 participant
@mabuchs