Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update base image to Python 3.12 in Dockerfile #10358

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Nov 6, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

See #10399

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@bowenliang123
Copy link
Contributor

Wow, cool. It's a step for raising the minimum supported Python version to 3.12 and bringing the new features from 3.11 and 3.12?

@laipz8200
Copy link
Member Author

@bowenliang123 I think the minimum supported Python version should be 3.11, at first.

@bowenliang123
Copy link
Contributor

SGTM. So are you considering using 3.11 in the dockerfile?

@laipz8200
Copy link
Member Author

I’d prefer to use 3.12 while keeping compatibility with 3.11, but it still needs some testing.

@bowenliang123
Copy link
Contributor

bowenliang123 commented Nov 6, 2024

Reasonable. Let's suggested to use Python 3.12 in docs for deployment and development, while maintaining support for 3.11 in tests.

The PR #10386 is raised to show the impacts of bumping the minimum version to 3.11.

@laipz8200 laipz8200 marked this pull request as ready for review November 22, 2024 11:33
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Nov 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@crazywoola crazywoola merged commit da601f0 into main Nov 22, 2024
9 checks passed
@crazywoola crazywoola deleted the chore/update-base-image-to-Python-3.12-in-Dockerfile branch November 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants