Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builtin tools for send email #10493

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

wakaka6
Copy link
Contributor

@wakaka6 wakaka6 commented Nov 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue need a tool for send email #10492
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #10492

Implementation of tools for sending e-mail

image

image

image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Nov 9, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change things below

  • remove the comments in the yaml file.
  • use the svg icon
  • fix the lints
    :)

@wakaka6
Copy link
Contributor Author

wakaka6 commented Nov 10, 2024

@crazywoola PTAL again. Thanks!

@crazywoola
Copy link
Member

The lint action is still failing. Please make sure run the ./dev/reformat before pushing it.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@crazywoola crazywoola merged commit 9c7edb9 into langgenius:main Nov 12, 2024
6 checks passed
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
@wilsonfe
Copy link

I couldn't send the email. I entered all the data and still couldn't send an email using sendgrid or Amazon SES.
image

image

In the tests, I entered an email address from the domain registered in my Amazon and Send Grid accounts. I entered the SendGrid and Amazon API passwords, as well as the password for one of the emails. All of these tests failed.
This email password issue is very confusing. Couldn't it be the API password? In any case, I tested both and neither worked.

@twinprime19
Copy link

This tool need to have the "from" address, which the user has to specify as the Verified Sender in Sendgrid. When using Sendgrid and not specifying this, sendgrid refuses. I tested my account with sendgrid directly and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need a tool for send email
4 participants