-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add builtin tools for send email #10493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change things below
- remove the comments in the yaml file.
- use the
svg
icon - fix the lints
:)
@crazywoola PTAL again. Thanks! |
The lint action is still failing. Please make sure run the |
This tool need to have the "from" address, which the user has to specify as the Verified Sender in Sendgrid. When using Sendgrid and not specifying this, sendgrid refuses. I tested my account with sendgrid directly and it works. |
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>
, see documentation for more details.Fixes #10492
Implementation of tools for sending e-mail
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration