Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set Celery LOG_File only when available, always log to console #10563

Conversation

fdb02983rhy
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fix #10555
Regarding Celery, only set the LOG_FILE variable to Difyconfig when its available. Besides, always log output to the console.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Fix the code, rebuild worker image, run docker compose.

image

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@crazywoola crazywoola merged commit 16db2c4 into langgenius:main Nov 11, 2024
6 checks passed
@yuzp-work
Copy link

Is this issue fixed? Trying to update from 0.10.1 to 0.11.1 in docker, looks still have this issue.

@verigle
Copy link

verigle commented Nov 12, 2024

not fix for 0.11.1

@fdb02983rhy
Copy link
Contributor Author

fdb02983rhy commented Nov 12, 2024

It happens after you update to 0.11.1, it should be fixed in the next release with this PR.

@crazywoola crazywoola mentioned this pull request Nov 12, 2024
5 tasks
@crazywoola
Copy link
Member

#10555 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery not starting correctly when LOG_FILE is empty
4 participants