Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: number maybe empty string #10743

Conversation

crazywoola
Copy link
Member

@crazywoola crazywoola commented Nov 15, 2024

Summary

Reproduce steps:

  • Import Issue 10727.yml.zip
  • Enter a number
  • Remove this number
  • Send a message to start the conversation

Fix #10727

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@crazywoola crazywoola requested a review from laipz8200 November 15, 2024 07:43
@crazywoola crazywoola linked an issue Nov 15, 2024 that may be closed by this pull request
5 tasks
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@crazywoola crazywoola merged commit 2fed55a into main Nov 15, 2024
9 checks passed
@crazywoola crazywoola deleted the fix/10727-optional-value-error-in-input-form-must-be-a-valid-number branch November 15, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional Value Error: in input form must be a valid number
2 participants