Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support function call for ollama block chat api #10784

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

GeorgeCaoJ
Copy link
Contributor

@GeorgeCaoJ GeorgeCaoJ commented Nov 17, 2024

Summary

Ollama’s Block Chat API supports function calls when the LLM includes this feature. In agent apps, the agent with ollama LLM will use Function Call mode instead of ReAct mode to prevent unexpected function executions.

Screenshots

Before: After:
截屏2024-11-17 21 35 13 截屏2024-11-17 22 05 22 截屏2024-11-17 21 44 38 截屏2024-11-17 21 44 03

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime labels Nov 17, 2024
@crazywoola crazywoola requested a review from laipz8200 November 18, 2024 01:47
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2024
@crazywoola crazywoola merged commit fbfc811 into langgenius:main Nov 20, 2024
6 checks passed
@crazywoola
Copy link
Member

image

@GeorgeCaoJ GeorgeCaoJ deleted the feat/ollama-function-call branch November 20, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants