-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor all 'or []' and 'or {}' logic to make code more clear #10883
fix: refactor all 'or []' and 'or {}' logic to make code more clear #10883
Conversation
This behavior is unexpected because sometimes the dictionary contains entries with |
However, some parts of the changes are worth keeping, and we can retain those. Could you avoid changing the |
yes I did not change that logic, please check~ |
copy that, will change the dict |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
1826db1
to
7fc88ea
Compare
fixed thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two points might need changed, please check my comments. 😊
api/core/model_runtime/model_providers/openllm/llm/openllm_generate.py
Outdated
Show resolved
Hide resolved
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
api/core/model_runtime/model_providers/openllm/llm/openllm_generate.py
Outdated
Show resolved
Hide resolved
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your detailed work~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice shots~
Summary
refactor most of the
or []
andor {}
logicmain is as it
or it
Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods