Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support streaming output for OpenAI o1-preview and o1-mini #10890

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Support streaming output for OpenAI o1-preview and o1-mini #10890

merged 2 commits into from
Nov 20, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Nov 20, 2024 •
edited
Loading

Summary

Close #10891

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime labels Nov 20, 2024
@laipz8200 laipz8200 requested a review from crazywoola November 20, 2024 06:03
@laipz8200 laipz8200 changed the title Feat/support-streaming-in-openai-o1-preview-&-o1-mini Feat/support-streaming-in-openai-o1-preview-and-o1-mini Nov 20, 2024
@laipz8200 laipz8200 changed the title Feat/support-streaming-in-openai-o1-preview-and-o1-mini Support streaming output for OpenAI o1-preview and o1-mini Nov 20, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2024
@crazywoola crazywoola merged commit 4d6b454 into main Nov 20, 2024
9 checks passed
@crazywoola crazywoola deleted the feat/support-streaming-in-openai-o1-preview-&-o1-mini branch November 20, 2024 07:10
@laipz8200 laipz8200 mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support streaming output for o1-preview and o1-mini
2 participants
@laipz8200 @crazywoola