Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat history might be empty in log detail view #10905

Conversation

xuzuodong
Copy link
Contributor

@xuzuodong xuzuodong commented Nov 20, 2024

Summary

Screenshots

Before: After:
image image

How did this happen?

When the fetched message list (10 items) is partial, and in the fetched list, there are more than one messages whose parent_message_id are temporarily unknown, the view will not display any records.

See message tree diagram below: the 93156a node is not yet fetched from backend, and there are multiple messages depend on it.

6051732094444_ pic

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 20, 2024
@xuzuodong xuzuodong marked this pull request as draft November 20, 2024 10:16
@xuzuodong xuzuodong marked this pull request as ready for review November 21, 2024 03:37
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 21, 2024
@xuzuodong xuzuodong changed the title fix: chat history empty in log detail view if multiple head is fix: chat history might be empty in log detail view Nov 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@crazywoola crazywoola merged commit ea0ebc0 into langgenius:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants