Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tiny lora bug found by mypy #10959

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Nov 22, 2024

Summary

fix: tiny lora bug found by mypy(not the type hint wrong)
its part of #10921 when we found some bugs when doing it, will make a small
pull request to benefit the project

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 marked this pull request as ready for review November 22, 2024 01:55
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 22, 2024
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@laipz8200 laipz8200 merged commit 464f384 into langgenius:main Nov 22, 2024
6 checks passed
@yihong0618 yihong0618 deleted the hy/fix_extract_loras_bug branch November 22, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants