Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json parse err when http node send request #11001

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

litterGuy
Copy link
Contributor

@litterGuy litterGuy commented Nov 23, 2024

When the node sends an http request parameter with \n\t\r, the json conversion error ValueError: Invalid control character at: line 1 column 8363 (char 8362)

Summary

When the request parameter carries '\t', '\n', '\r' and is sent in application/json format, an error "ValueError: Invalid control character at: line 1 column 8363 (char 8362)" will be reported.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 24, 2024
When the node sends an http request parameter with \n\t\r, the json conversion error ValueError: Invalid control character at: line 1 column 8363 (char 8362)
@crazywoola crazywoola merged commit ae3a2cb into langgenius:main Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants