Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query will be None if the query_prompt_template not exists #11031

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Nov 24, 2024

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 24, 2024
@laipz8200 laipz8200 requested a review from crazywoola November 24, 2024 07:12
@laipz8200 laipz8200 marked this pull request as draft November 24, 2024 07:13
…sts.

Signed-off-by: -LAN- <laipz8200@outlook.com>
@laipz8200 laipz8200 force-pushed the fix/fetch-query-in-llm-node branch from ca1a1b5 to 2620495 Compare November 24, 2024 07:35
@laipz8200 laipz8200 changed the title fix(llm_node): Fetch query from system variable. fix: query will be None if the query_prompt_template not exists Nov 24, 2024
@laipz8200 laipz8200 marked this pull request as ready for review November 24, 2024 07:36
@dosubot dosubot bot added the 🐞 bug Something isn't working label Nov 24, 2024
@laipz8200 laipz8200 self-assigned this Nov 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 24, 2024
@crazywoola crazywoola merged commit 60b5dac into main Nov 24, 2024
8 checks passed
@crazywoola crazywoola deleted the fix/fetch-query-in-llm-node branch November 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants