Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file_factory): convert tool file correctly. #11167

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Nov 27, 2024

Summary

  1. Use default "custom" in file type.
  2. Skip validate when the config not pass.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

1. Use default "custom" in file type.
2. Skip validate when the `config` not pass.

Signed-off-by: -LAN- <laipz8200@outlook.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 27, 2024
@laipz8200 laipz8200 requested a review from crazywoola November 27, 2024 08:29
@yihong0618
Copy link
Contributor

cool

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2024
@crazywoola crazywoola merged commit 787285d into main Nov 27, 2024
8 checks passed
@crazywoola crazywoola deleted the fix/convert-file-from-tool-result branch November 27, 2024 09:28
@FascinatingIsland
Copy link

Still not work at cloud.dify.ai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants