Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'validation error for ToolInvokeMessage' when blob_message meta is None #11212

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

catusax
Copy link
Contributor

@catusax catusax commented Nov 29, 2024

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

this change fix a issue when custom tool returns a blob message without metadata, a

validation error for ToolInvokeMessage\nmeta\n Input should be a valid dictionary

will be throwed, because meta definition is meta: dict[str, Any] = Field(default_factory=dict) which can not be set to None.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 29, 2024
@crazywoola crazywoola requested a review from laipz8200 November 29, 2024 08:41
api/core/tools/tool/tool.py Outdated Show resolved Hide resolved
@catusax
Copy link
Contributor Author

catusax commented Nov 29, 2024

u r right! @laipz8200 , i have recovered the function signature

laipz8200
laipz8200 previously approved these changes Nov 29, 2024
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 29, 2024
@crazywoola crazywoola merged commit d96a284 into langgenius:main Nov 29, 2024
5 checks passed
@catusax catusax deleted the patch-1 branch November 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants