Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support file download in workflow result #11338

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

JzoNgKVO
Copy link
Collaborator

@JzoNgKVO JzoNgKVO commented Dec 4, 2024

Summary

Fix #9147

Screenshots

image

image

image

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@JzoNgKVO JzoNgKVO marked this pull request as ready for review December 5, 2024 07:34
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. 🐞 bug Something isn't working labels Dec 5, 2024
@JzoNgKVO JzoNgKVO requested a review from crazywoola December 5, 2024 07:35
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@JzoNgKVO JzoNgKVO merged commit 0b25c0b into main Dec 5, 2024
7 checks passed
@JzoNgKVO JzoNgKVO deleted the feat/support-file-download-in-workflow branch December 5, 2024 08:58
@Linktime
Copy link

Linktime commented Dec 5, 2024

I get "TypeError: Cannot read properties of null (reading 'dify_model_identity')"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Add the option to download the Results of a workflow as a FILE
3 participants