-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the processing of single quote when testing API tools. #11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
🐞 bug
Something isn't working
labels
Dec 5, 2024
@hjlarry Could you please review this issue? I believe we do not require support for single quotes in this instance. Perhaps we could consider removing this feature instead. |
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Dec 10, 2024
weimzh
changed the title
Fix issue with using an JSON object with single quote in a string when testing API tools.
Remove the processing of single quote when testing API tools.
Dec 10, 2024
laipz8200
reviewed
Dec 10, 2024
Simply replacing the single quote with double quote will cause issue if some string in the JSON object contains single quotes.
hjlarry
approved these changes
Dec 10, 2024
laipz8200
approved these changes
Dec 10, 2024
Thank you for your contribution! |
iamjoel
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with using an JSON object with single quote in a string when testing API tools.
Simply replacing the single quote with double quote will cause issue if some string in the JSON object contains single quotes. This fixes the issue.
For example:
{"key": "value 'test'"}
the original code in Dify will simply replace the simple quotes into double quotes, ie:
{"key": "value 'test'"} -> {"key": "value "test""}, which will definitely cause problems.
Checklist
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods