Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 11247 that Completion mode content maybe list or str #11504

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: issue 11247 that Completion mode content maybe list or str #11504

merged 1 commit into from
Dec 10, 2024

Conversation

yihong0618
Copy link
Contributor

Summary

close #11247

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@yihong0618
fix: issue 11247 that Completion mode content maybe list or str
e0adc8f 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 9, 2024
@crazywoola crazywoola requested a review from laipz8200 December 10, 2024 00:49
laipz8200
laipz8200 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@laipz8200 laipz8200 merged commit 7165760 into langgenius:main Dec 10, 2024
5 checks passed
@yihong0618 yihong0618 mentioned this pull request Dec 11, 2024
Closed
5 tasks
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
@yihong0618 @iamjoel
fix: issue 11247 that Completion mode content maybe list or str (#11504)
a571914 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@laipz8200 laipz8200 mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug ollama model actions: qwq:32b-preview-fp16, bug occur 'can only concatenate str (not "list") to str'
2 participants
@yihong0618 @laipz8200