Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : fix translation Typo in ko-KR localization #11509

Conversation

JungHyunMoon
Copy link
Contributor

Summary

This PR resolves a translation issue in the Korean (ko-KR) localization file dataset-documents.ts for embedding metrics. Both "Embedding Time" and "Embedding Spend" were previously translated as "임베딩 시간," causing user confusion. The term "Embedding Spend" has been corrected to "임베딩 소모" to differentiate between the two metrics.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

- Changed "임베딩 시간" to "임베딩 소모" for "Embedding Spend"
- Ensured proper differentiation between "Embedding Time" and "Embedding Spend"
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@crazywoola crazywoola merged commit 8218f62 into langgenius:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants