Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app log filter value error #11624

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix: app log filter value error #11624

merged 3 commits into from
Dec 13, 2024

Conversation

Kevin9703
Copy link
Contributor

@Kevin9703 Kevin9703 commented Dec 13, 2024

Summary

The parameters were not properly passed when selecting 'allTime' because the type in onSelect logic was set to string (should have been number).

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2024
@crazywoola crazywoola merged commit bdfdccd into langgenius:main Dec 13, 2024
4 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants