Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max_submit_count configurable via Config #11673

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

kazuhisa-wada
Copy link
Contributor

@kazuhisa-wada kazuhisa-wada commented Dec 15, 2024

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Mage max_submit_count configurable via Config. This is the action closes #11668

Screenshots

Before
please see screenshots in #11668

After
image
image
image
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

For test code, I haven't added any test code for this as this change is limited to parameter related to limits.
For document, there is no document to be changed.
For dev/reformat, I ran it as follows:
image

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 15, 2024
@crazywoola
Copy link
Member

Please fix the lint :)

@yihong0618
Copy link
Contributor

  1. seems you need to check ruff version
  2. maybe we can add the config to .env too?

@kazuhisa-wada
Copy link
Contributor Author

Apologies. Let me do.

@yihong0618
Copy link
Contributor

2. ybe we can add the config to .en

ruff version print in the actions

@kazuhisa-wada
Copy link
Contributor Author

maybe we can add the config to .env too?

Sorry, I missed this mention. Adding .env.example....

@kazuhisa-wada
Copy link
Contributor Author

I've completed adding it to .env.example.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@crazywoola crazywoola merged commit 63f1dd7 into langgenius:main Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
3 participants