Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: messagefeedbackapi support content #11716

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Conversation

liuhaoran1212
Copy link
Contributor

Summary

This submission resolves the issue that the messagefeebackapi does not support content fields.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Fixed #11704

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Signed-off-by: weiyang <24080293@smb956101.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 17, 2024
@crazywoola
Copy link
Member

Please update the docs in *.mdx files as well.

@liuhaoran1212 liuhaoran1212 changed the title messagefeedbackapi support content fix: messagefeedbackapi support content Dec 19, 2024
@liuhaoran1212
Copy link
Contributor Author

Please update the docs in *.mdx files as well.

Please update the docs in *.mdx files as well.

Okey, how do I update *.mdx files? Do I modify it manually? Or is there a corresponding template?

@crazywoola
Copy link
Member

image

@liuhaoran1212
Copy link
Contributor Author

liuhaoran1212 commented Dec 20, 2024

Do I only need to modify template_advanced_chat.en.mdx? and do I need to modify *.mdx files of other language types (such as template_advanced_chat.ja.mdx)?

Signed-off-by: weiyang <24080293@smb956101.com>
@crazywoola
Copy link
Member

Do I only need to modify template_advanced_chat.en.mdx? and do I need to modify *.mdx files of other language types (such as template_advanced_chat.ja.mdx)?

You need to update all mdx files.

Signed-off-by: weiyang <24080293@smb956101.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 21, 2024
@liuhaoran1212
Copy link
Contributor Author

Do I only need to modify template_advanced_chat.en.mdx? and do I need to modify *.mdx files of other language types (such as template_advanced_chat.ja.mdx)?

You need to update all mdx files.

Ok, I have modified all the *.mdx files.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 22, 2024
@crazywoola crazywoola merged commit 6b49889 into langgenius:main Dec 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
2 participants