Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tidb service optional with proper profile in docker compose yaml #11729

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

bowenliang123
Copy link
Contributor

Summary

  • adding profile in docker compose for tidb container , making it optional without starting it by default

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 17, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Dec 17, 2024

cc @laipz8200 @JohnJyong @crazywoola

@bowenliang123 bowenliang123 marked this pull request as draft December 17, 2024 05:17
@bowenliang123
Copy link
Contributor Author

Let me check whether it works, without exposing the port 4000 to the host.

@bowenliang123 bowenliang123 force-pushed the docker-tidb-profile branch 2 times, most recently from d0b9fa9 to 1fea7e2 Compare December 17, 2024 05:42
@bowenliang123 bowenliang123 marked this pull request as ready for review December 17, 2024 05:44
@bowenliang123 bowenliang123 changed the title fix: adding profile to the optional tidb container in docker compose fix: make tidb service optional with proper profile in docker compose yaml Dec 17, 2024
@crazywoola crazywoola requested a review from laipz8200 December 17, 2024 05:51
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 17, 2024
@laipz8200 laipz8200 merged commit 78c3051 into langgenius:main Dec 17, 2024
14 checks passed
@bowenliang123 bowenliang123 deleted the docker-tidb-profile branch December 17, 2024 06:27
jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants