Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unquote urls in docker-compose.yaml #12072

Merged
merged 3 commits into from
Dec 25, 2024
Merged

fix: unquote urls in docker-compose.yaml #12072

merged 3 commits into from
Dec 25, 2024

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Dec 25, 2024 •
edited
Loading

Quotes around default urls seem to cause errors like below. Some crash the system even before starting. Removing them fixed the issue for me.

ValueError: Unknown scheme for proxy URL URL('"http://ssrf_proxy:3128"')

CODE_EXECUTION_ENDPOINT
  Input should be a valid URL, relative URL without a base [type=url_parsing, input_value='"http://sandbox:8194/"', input_type=str]

2024-12-25 07:55:38,602.602 WARNING [Dummy-2] [version.py:37] - Check update version error: No connection adapters were found for '"https://updates.dify.ai"'.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 25, 2024
laipz8200
laipz8200 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 25, 2024
@laipz8200 laipz8200 merged commit 1885d3d into langgenius:main Dec 25, 2024
7 checks passed
@cemremengu cemremengu deleted the patch-1 branch December 25, 2024 08:35
@laipz8200 laipz8200 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cemremengu @laipz8200