Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow fallback to remote_url when url is not provided #12455

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

fujita-h
Copy link
Contributor

@fujita-h fujita-h commented Jan 7, 2025

Summary

When handling files from a URL, the parameter should be remote_url, so this function should also get it from remote_url. However, the actual implementation references the url parameter.
I was unable to confirm whether the url parameter was actually used, so the original parameter implementation has been left intact.
If the url parameter is not used, you can delete this part.

Fixes #12454
Also Fixes #12209

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2025
@crazywoola crazywoola merged commit 4295cef into langgenius:main Jan 7, 2025
5 checks passed
@fujita-h fujita-h deleted the fix-url-mapping branch January 7, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Under certain conditions, the access log cannot be displayed from the Web UI preview chatflow logs errors
2 participants