Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same chunk insert deadlock #12502

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

huangzhuo1949
Copy link
Contributor

@huangzhuo1949 huangzhuo1949 commented Jan 8, 2025

Summary

Distribute documents into multiple groups based on the hash values of page_content.
This is done to prevent multiple threads from processing the same document, thereby avoiding potential database insertion deadlocks.

fix #12481

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@dosubot dosubot bot added the 🐞 bug Something isn't working label Jan 8, 2025
@crazywoola
Copy link
Member

Please fix the tests.

@huangzhuo1949
Copy link
Contributor Author

Please fix the tests.

done~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2025
@JohnJyong JohnJyong merged commit e84bf35 into langgenius:main Jan 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psycopg2.errors.DeadlockDetected: deadlock detected
3 participants