Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to change profile avatar #12642

Merged
merged 22 commits into from
Jan 22, 2025

Conversation

miya
Copy link
Contributor

@miya miya commented Jan 11, 2025

Summary

close: #12641

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenrecord

2025-01-11.20.42.27.mov

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 💪 enhancement New feature or request labels Jan 11, 2025
@miya miya marked this pull request as draft January 11, 2025 12:10
@miya miya marked this pull request as ready for review January 11, 2025 12:31
@crazywoola crazywoola self-requested a review January 13, 2025 02:22
@crazywoola
Copy link
Member

crazywoola commented Jan 13, 2025

image.
I am testing it however I could not click the save button, it's always loading.

@miya
Copy link
Contributor Author

miya commented Jan 13, 2025

@crazywoola

Thank you for testing. I've made some modifications, so could you please update your branch and test it again? If it's still not working properly, I would appreciate if you could check the status of requests to the following endpoints in your browser's Dev Tools Network tab? These requests should trigger when you click the OK button after attaching an image.

  • POST: /console/api/files/upload
  • POST: /console/api/account/avatar

When working properly, it should behave like in the following video.

2025-01-13.20.22.17.mov

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@crazywoola crazywoola merged commit f582d4a into langgenius:main Jan 22, 2025
7 checks passed
@miya miya deleted the feat/add-profile-avatar-change branch January 22, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize user avatars
2 participants